Commit to fix descendants and subtree methods to work properly with scopes that use joins #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… use joins by including the table name in the condition sql.
|
I'm having this same problem, +1 for merging into main |
|
+1 |
|
Same problem here +1 |
…operly with scopes that use joins by including the table name in the condition sql.
|
Didn't realize I made this pull request off my master. I'm gonna close this and re-request off my branch for join fixes. Feel free to re-bump it :) |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the descendants and subtree methods use raw sql as part of their conditions, using them with another scope method breaks if that scope uses joins. This commit fixes that by adding the table name to the sql.